After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774421 - Two minor patches
Two minor patches
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
2.50.x
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-11-14 17:33 UTC by Ross Burton
Modified: 2016-11-14 18:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't shadow rand() (1.34 KB, patch)
2016-11-14 17:33 UTC, Ross Burton 		committed Details | Review
Use @datadir@ (663 bytes, patch)
2016-11-14 17:33 UTC, Ross Burton 		committed Details | Review

Description Ross Burton 2016-11-14 17:33:05 UTC 
Created attachment 339823 [details] [review]
Don't shadow rand()

Pushing upstream some patches we've been sitting on for years.
Comment 1 Ross Burton 2016-11-14 17:33:24 UTC 
Created attachment 339824 [details] [review]
Use @datadir@
Comment 2 Emmanuele Bassi (:ebassi) 2016-11-14 17:34:37 UTC 
Review of attachment 339823 [details] [review]:

Looks good.
Comment 3 Emmanuele Bassi (:ebassi) 2016-11-14 17:34:54 UTC 
Review of attachment 339824 [details] [review]:

Looks good.
Comment 4 Emmanuele Bassi (:ebassi) 2016-11-14 18:34:09 UTC 
Thanks, pushed both attachments to master.