After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774394 - gir break since commit 463d94d6022d
gir break since commit 463d94d6022d
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-11-14 09:00 UTC by Marinus Schraal
Modified: 2016-11-14 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Add header back needed for GI (950 bytes, patch)
2016-11-14 09:36 UTC, Marinus Schraal 		none Details | Review
core: Add back header needed for GI (950 bytes, patch)
2016-11-14 09:38 UTC, Marinus Schraal 		none Details | Review
core: Include type'ified header in introspection (1.09 KB, patch)
2016-11-14 13:37 UTC, Bastien Nocera 		committed Details | Review

Description Marinus Schraal 2016-11-14 09:00:38 UTC 
Since commit 463d94d6022d this happens during the build :

GISCAN   Grl-0.3.gir
<unknown>:: Warning: Grl: (Signal)content-changed: argument change_type: Unresolved type: 'GrlSourceChangeType'

in music this results in a crash on the content-changed signal

    [self.pending_changed_medias.append(media) for media in changedMedias]
TypeError: 'PtrArray' object is not iterable
Comment 1 Marinus Schraal 2016-11-14 09:36:36 UTC 
Created attachment 339784 [details] [review]
core: Add header back needed for GI

grl-type-builtins.h is needed for generating correct GI bindings.
Comment 2 Marinus Schraal 2016-11-14 09:38:00 UTC 
Created attachment 339785 [details] [review]
core: Add back header needed for GI

grl-type-builtins.h is needed for generating correct GI bindings.

--
I'm not sure this is the correct solution, but it does work.
Comment 3 Bastien Nocera 2016-11-14 13:37:12 UTC 
Created attachment 339801 [details] [review]
core: Include type'ified header in introspection

Introspection sources need to include the type'ified enumerations
otherwise the gir-scanner won't know anything about the enumerations
listed in that header, generated with glib-mkenums.

Fix-up to commit 463d94d6022d
Comment 4 Bastien Nocera 2016-11-14 13:38:28 UTC 
Attachment 339801 [details] pushed as 2802eaf - core: Include type'ified header in introspection

I fixed up the commit message as well.