After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774343 - decodebin3: Clear saw_eos flag of DecodebinInputStream by FLUSH event
decodebin3: Clear saw_eos flag of DecodebinInputStream by FLUSH event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-13 04:21 UTC by Seungha Yang
Modified: 2016-11-15 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
decodebin3: Clear saw_eos flag of DecodebinInputStream by FLUSH event (1.65 KB, patch)
2016-11-13 04:22 UTC, Seungha Yang 		none Details | Review

Description Seungha Yang 2016-11-13 04:21:15 UTC 
decodebin3: Clear saw_eos flag of DecodebinInputStream by FLUSH event

Likewise how GstPad is doing, saw_eos flag of DecodebinInputStream
must be cleared by FLUSH event.
Comment 1 Seungha Yang 2016-11-13 04:22:07 UTC 
Created attachment 339734 [details] [review]
decodebin3: Clear saw_eos flag of DecodebinInputStream by FLUSH event
Comment 2 Seungha Yang 2016-11-13 04:32:43 UTC 
In case of following sequence, decodebin3 pushes EOS event too early.

<DASH streaming case with DASHdemux>
Seq 1. dashdemux finished segment downloading, and push all date followed by EOS
Seq 2. parsebin's srcpads of Video/Audio detect EOS event, and set "saw_eos" flag.
Seq 3. Seek -> flush start/stop
Seq 4. dashdemux finish segment downloading, and push EOS again
Seq 5. one of parsebin's srcpad detects EOS (the other srcpad of parsebin does not detect EOS yet).
Seq 6. Due to saw_eos flag of Seq 2 (flush did not clear saw_eos flag), decodebin3 pushes EOS event to the all MultiqueueSlots, although streaming was not finished yet.
Comment 3 Jan Schmidt 2016-11-15 10:39:29 UTC 
Thanks, pushed (to master and 1.10):

commit 364a45267e3e50a5434ca2e92e341634af1ffaab
Author: Seungha Yang <sh.yang@lge.com>
Date:   Sun Nov 13 13:15:38 2016 +0900

    decodebin3: Clear saw_eos flag of DecodebinInputStream by FLUSH event
    
    Likewise how GstPad is doing, saw_eos flag of DecodebinInputStream
    must be cleared by FLUSH event.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774343