GNOME Bugzilla – Bug 774286
Take advantage of Unicode
Last modified: 2017-01-31 15:10:57 UTC
Created attachment 339642 [details] [review] data: Use Unicode in translatable strings Attached patches convert ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Created attachment 339643 [details] [review] main: Use Unicode in translatable strings
Created attachment 339644 [details] [review] backend: Use Unicode in translatable strings
Created attachment 339645 [details] [review] lirc: Use Unicode in translatable strings
Created attachment 339646 [details] [review] properties: Use Unicode in translatable strings
Created attachment 339647 [details] [review] pythonconsole: Use Unicode in translatable strings
Created attachment 339648 [details] [review] screenshot: Use Unicode in translatable strings
Created attachment 339649 [details] [review] skipto: Use Unicode in translatable strings
Review of attachment 339642 [details] [review]: ++
Review of attachment 339643 [details] [review]: ::: src/totem-interface.c @@ +177,3 @@ char *msg; + msg = g_strdup_printf (_("Couldn’t load the “%s” interface. %s"), name, _("The file does not exist.")); I'm not a fan of changing the single quotation marks into double quotation marks. Please don't do that. (We discussed this when you provided the Unicode patches for libgdata.)
Review of attachment 339644 [details] [review]: ++
Review of attachment 339645 [details] [review]: ++
Review of attachment 339646 [details] [review]: ++
Review of attachment 339647 [details] [review]: ::: src/plugins/pythonconsole/pythonconsole.py @@ +89,3 @@ console.set_size_request (600, 400) # pylint: disable-msg=E1101 console.eval ('print("%s" %% totem_object)' % _("You can access "\ + "the Totem.Object through “totem_object” :\\n%s"), False) Please don't change the single quotes into double quotes. Also, I suspect Python will now need the string to be marked as Unicode, and the output to be encoded as UTF-8 before it's passed to `console.eval()`. Have you tested this?
Review of attachment 339648 [details] [review]: ++
Review of attachment 339649 [details] [review]: ++
(In reply to Philip Withnall from comment #9) > Review of attachment 339643 [details] [review] [review]: > I'm not a fan of changing the single quotation marks into double quotation > marks. Please don't do that. I think it's a matter of both internal consistency (totem uses double quotation marks everywhere else) and consistency with other GNOME apps that also use double quotation marks, as GNOME HIG recommends. (In reply to Philip Withnall from comment #13) > Review of attachment 339647 [details] [review] [review]: > Also, I suspect Python will now need the string to be marked as Unicode, and > the output to be encoded as UTF-8 before it's passed to `console.eval()`. > Have you tested this? I have not, but if it's broken with Unicode, then it was already broken in most localizations.
(In reply to Piotr Drąg from comment #16) > (In reply to Philip Withnall from comment #9) > > Review of attachment 339643 [details] [review] [review] [review]: > > I'm not a fan of changing the single quotation marks into double quotation > > marks. Please don't do that. > > I think it's a matter of both internal consistency (totem uses double > quotation marks everywhere else) and consistency with other GNOME apps that > also use double quotation marks, as GNOME HIG recommends. If you want to make the use of single vs double quotation marks consistent within Totem, that ideally belongs as a separate commit. Or at least requires some justification in the commit message. > (In reply to Philip Withnall from comment #13) > > Review of attachment 339647 [details] [review] [review] [review]: > > Also, I suspect Python will now need the string to be marked as Unicode, and > > the output to be encoded as UTF-8 before it's passed to `console.eval()`. > > Have you tested this? > > I have not, but if it's broken with Unicode, then it was already broken in > most localizations. I just did a quick test, and it looks like the gettext.gettext method handles the encoding correctly already, so you’re right, and no further changes are needed here.
Created attachment 339748 [details] [review] main: Use Unicode in translatable strings I added an explanation to the commit message.
Created attachment 339749 [details] [review] pythonconsole: Use Unicode in translatable strings Ditto.
Review of attachment 339748 [details] [review]: I still disagree that the HIG recommends double quotation marks over single ones, but this is not worth bikeshedding over.
Review of attachment 339749 [details] [review]: The explanation has ended up above the bug link in the commit message. Please move the bug link to a line by itself at the bottom of the message before you push. I still disagree that the HIG recommends double quotation marks over single ones, but this is not worth bikeshedding over.
Thank you. I will correct the commit message and push after the branching for 3.22.
Pushed, thank you.