After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774283 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks: 772263
 
 
Reported: 2016-11-11 16:55 UTC by Piotr Drąg
Modified: 2016-11-11 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use Unicode in translatable strings (5.92 KB, patch)
2016-11-11 16:55 UTC, Piotr Drąg 		none Details | Review
Use Unicode in translatable strings (5.96 KB, patch)
2016-11-11 17:06 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2016-11-11 16:55:10 UTC 
Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Piotr Drąg 2016-11-11 16:55:29 UTC 
Created attachment 339638 [details] [review]
Use Unicode in translatable strings
Comment 2 Florian Müllner 2016-11-11 17:02:10 UTC 
Review of attachment 339638 [details] [review]:

::: data/resources/help-overlay.ui
@@ +101,3 @@
               <object class="GtkShortcutsShortcut">
                 <property name="visible">True</property>
+                <property name="title" translatable="yes" context="shortcut window">First — Ninth Room</property>

This is a range and should use en dash according to your link (not em dash)
Comment 3 Piotr Drąg 2016-11-11 17:06:34 UTC 
Created attachment 339640 [details] [review]
Use Unicode in translatable strings

Yes, of course.
Comment 4 Florian Müllner 2016-11-11 17:16:37 UTC 
Review of attachment 339640 [details] [review]:

LGTM, thanks
Comment 5 Piotr Drąg 2016-11-11 17:29:00 UTC 
Comment on attachment 339640 [details] [review]
Use Unicode in translatable strings

Pushed, thank you.