After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774208 - videoencoder: Timecode-based force-key-unit events
videoencoder: Timecode-based force-key-unit events
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 774209
 
 
Reported: 2016-11-10 13:41 UTC by Vivia Nikolaidou
Modified: 2017-01-09 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-video-event-Add-option-to-attach-a-timecode-to-an-ev.patch (2.31 KB, patch)
2016-11-10 13:42 UTC, Vivia Nikolaidou 		none Details | Review
0002-videoencoder-Timecode-based-force-key-unit-events.patch (5.28 KB, patch)
2016-11-10 13:43 UTC, Vivia Nikolaidou 		none Details | Review
0001-video-event-Add-option-to-attach-a-timecode-to-an-ev.patch (4.10 KB, patch)
2016-11-11 13:57 UTC, Vivia Nikolaidou 		none Details | Review

Description Vivia Nikolaidou 2016-11-10 13:41:29 UTC 
video-event: Add option to attach a timecode to an event

    videoencoder: Timecode-based force-key-unit events
    
    If a timecode is attached to both the force-key-unit event and the video
    frame, the force_key_unit event will be based on the timecode.
    Otherwise, it will be based on the running time as before.
Comment 1 Vivia Nikolaidou 2016-11-10 13:42:45 UTC 
Created attachment 339486 [details] [review]
0001-video-event-Add-option-to-attach-a-timecode-to-an-ev.patch
Comment 2 Vivia Nikolaidou 2016-11-10 13:43:01 UTC 
Created attachment 339487 [details] [review]
0002-videoencoder-Timecode-based-force-key-unit-events.patch
Comment 3 Tim-Philipp Müller 2016-11-11 12:21:36 UTC 
Please add some gtk-doc chunks with since: 1.12 markers for the new API, and add it to the .def file (make check-exports) and the libgstvideo docs :)
Comment 4 Vivia Nikolaidou 2016-11-11 13:57:43 UTC 
Created attachment 339623 [details] [review]
0001-video-event-Add-option-to-attach-a-timecode-to-an-ev.patch

Thanks, patch updated.
Comment 5 Sebastian Dröge (slomo) 2017-01-09 16:21:08 UTC 
As Vivia said, this is not needed anymore and solved differently now. It was for splitmuxsink but that works different now.

If someone ever needs this feature again later, we can revisit that.