After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774181 - 3.22: NSS and NSPR should be required independently and unconditionally
3.22: NSS and NSPR should be required independently and unconditionally
Status: RESOLVED WONTFIX
Product: evolution-data-server
Classification: Platform
Component: general
3.22.x (obsolete)
Other Mac OS
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks: 774453
 
 
Reported: 2016-11-10 07:01 UTC by Philip Chimento
Modified: 2016-11-27 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Check for NSS and NSPR independently (7.80 KB, patch)
2016-11-10 07:02 UTC, Philip Chimento
rejected Details | Review

Description Philip Chimento 2016-11-10 07:01:59 UTC
The logic in configure.ac checking for NSPR and NSS is not quite right - it fails if you have NSPR installed from pkg-config and NSS flags specified manually, for example. This should clean it up a bit, and do the checks independently and unconditionally.
Comment 1 Philip Chimento 2016-11-10 07:02:35 UTC
Created attachment 339436 [details] [review]
build: Check for NSS and NSPR independently

NSS and NSPR are required even if --disable-smime is given, so check for
them independently of each other and of the SMIME option.
Comment 2 Milan Crha 2016-11-10 14:11:43 UTC
Thanks for a bug report and patch, but I'm not going to change such fundamental thing in the stable release. The development version doesn't use autotools, it uses CMake, thus your patch is not going to be committed.
Comment 3 Philip Chimento 2016-11-11 06:11:00 UTC
OK, I'm trying to create a stable JHBuild setup for 3.22 on macOS, I'll see if I can get it to work with the NSS and NSPR that I'm currently building (I had several different configurations over the past few days).

Otherwise I'll have to use a tarball of e-d-s with my patch applied.
Comment 4 Milan Crha 2016-11-22 09:05:30 UTC
Right, that's the only option for the stable branch. If you'd have anything for CMake (git master branch), then feel free to share it, just note that as it is now it's either both or nothing (NSS & NSPR) in the code, which reflects the way it is looked for it in the configure itself. You still can build with -DENABLE_SMIME=OFF, which is intentional.
Comment 5 Philip Chimento 2016-11-27 20:46:26 UTC
I didn't save my build logs unfortunately, but it seems that NSS and NSPR are still required by parts of Camel even if building without SMIME. I'm not sure if _that_ was intentional, but I assumed it was.

In any case, I fixed this problem in a different way.