After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773892 - network: Summarize sections with too many devices
network: Summarize sections with too many devices
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 781406 785209 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-11-03 13:07 UTC by Florian Müllner
Modified: 2017-07-21 08:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Summarize sections with too many devices (5.15 KB, patch)
2016-11-03 13:07 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-11-03 13:07:11 UTC 
See patch.
Comment 1 Florian Müllner 2016-11-03 13:07:15 UTC 
Created attachment 339020 [details] [review]
network: Summarize sections with too many devices

Any network devices appear as top level items in the system status
menu, so on system with an unusually high number of devices, the
menu can end up exceeding the available screen height. While this
is a corner case, leaving important system actions unreachable is
bad. The system menu does not lend itself to scrolling, so handle
this case instead by summarizing sections ("n connections") where
the number of devices exceeds a threshold.
Comment 2 Rui Matos 2016-11-07 15:31:33 UTC 
Review of attachment 339020 [details] [review]:

lgtm

::: js/ui/status/network.js
@@ -1633,3 @@
-        this._devices.wired = this._createDeviceCategory();
-        this._devices.wireless = this._createDeviceCategory();
-        this._devices.wwan = this._createDeviceCategory();

ugh, these literal object prop names, good riddance
Comment 3 Florian Müllner 2016-11-10 13:40:56 UTC 
Attachment 339020 [details] pushed as b3fabf1 - network: Summarize sections with too many devices
Comment 4 Florian Müllner 2017-04-24 09:24:26 UTC 
*** Bug 781406 has been marked as a duplicate of this bug. ***
Comment 5 Florian Müllner 2017-07-21 08:06:50 UTC 
*** Bug 785209 has been marked as a duplicate of this bug. ***