After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773638 - wasapisrc, wasapisink: Allow to select device by passing WASAPI Endpoint ID
wasapisrc, wasapisink: Allow to select device by passing WASAPI Endpoint ID
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-28 15:21 UTC by Marcin Lewandowski
Modified: 2018-01-31 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add endpoint-id property (12.66 KB, patch)
2016-10-28 15:21 UTC, Marcin Lewandowski 		none Details | Review
Add endpoint-id property (12.67 KB, patch)
2016-10-28 15:28 UTC, Marcin Lewandowski 		none Details | Review
Add endpoint-id property (12.71 KB, patch)
2016-10-31 17:54 UTC, Marcin Lewandowski 		none Details | Review

Description Marcin Lewandowski 2016-10-28 15:21:10 UTC 
Created attachment 338736 [details] [review]
Add endpoint-id property

The attached patch allows to set the device (called Endpoint ID in WASAPI terminology) in wasapisrc and wasapisink
Comment 1 Marcin Lewandowski 2016-10-28 15:28:20 UTC 
Created attachment 338737 [details] [review]
Add endpoint-id property

Add endpoint-id property
Comment 2 Sebastian Dröge (slomo) 2016-10-31 10:29:54 UTC 
Review of attachment 338737 [details] [review]:

Generally looks good

::: sys/wasapi/gstwasapisink.c
@@ +42,3 @@
+enum
+{
+  PROP_ENDPOINT_ID

0 is not a valid property id (that's why there's often an unused PROP_0). I wonder why this didn't fail in various ways for you when you tried it.

@@ +200,3 @@
+          ("Failed to get default device"));
+      goto beach;
+    }

You might want to store this in self->endpoint_id then and do a g_object_notify()
Comment 3 Marcin Lewandowski 2016-10-31 17:54:21 UTC 
Created attachment 338836 [details] [review]
Add endpoint-id property
Comment 4 Marcin Lewandowski 2016-10-31 17:55:22 UTC 
I have added missing PROP_0, but honestly speaking I don't fully understand your second comment?
Comment 5 Nirbheek Chauhan 2018-01-31 10:32:08 UTC 
This is now fixed in -bad with the "device" property which takes a string endpoint id: https://bugzilla.gnome.org/show_bug.cgi?id=792897

Can you please try the latest code in -bad and verify that it's fixed for you too?