After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773634 - browser-plugin: The NPObject returned by NPP_GetValue should be retained
browser-plugin: The NPObject returned by NPP_GetValue should be retained
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-28 13:32 UTC by Carlos Garcia Campos
Modified: 2016-10-29 07:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
browser-plugin: The NPObject returned by NPP_GetValue should be retained (835 bytes, patch)
2016-10-28 13:34 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2016-10-28 13:32:15 UTC 
This is causing crashes in some browsers.
Comment 1 Carlos Garcia Campos 2016-10-28 13:34:21 UTC 
Created attachment 338720 [details] [review]
browser-plugin: The NPObject returned by NPP_GetValue should be retained
Comment 2 Sergio Villar 2016-10-28 13:47:28 UTC 
\o/
Comment 3 Michael Catanzaro 2016-10-28 15:27:38 UTC 
Review of attachment 338720 [details] [review]:

Thanks. Be sure to commit also to gnome-3-22.

Ideally you would describe in the commit message why, since I have no clue.
Comment 4 Michael Catanzaro 2016-10-28 15:41:14 UTC 
You could just copy/paste your explanation from the WebKit bug into the commit message, that would be great.
Comment 5 Carlos Garcia Campos 2016-10-29 07:14:36 UTC 
Comment on attachment 338720 [details] [review]
browser-plugin: The NPObject returned by NPP_GetValue should be retained

Pushed to both branches.