After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773593 - plugins: ensure display when getting raw caps
plugins: ensure display when getting raw caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-27 16:17 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-11-04 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
plugins: ensure display when getting raw caps (2.71 KB, patch)
2016-10-27 16:17 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-10-27 16:17:04 UTC
When running gst-discoverer-1.0, in certain media, vaapipostroc is stopped
meanwhile it is transforming caps. The problem is stop() calls
gst_vaapi_plugin_base_close(), which nullifies the element's va display, but
the va display is used in tranform_caps() when it is extracting the possible
format conversions. This display disappearing generates warning messages.

This patch holds a local reference of va display at ensure_allowed_raw_caps()
hence it doesn't go away meanwhile it is used, even if the
gst_vaapi_plugin_base_close() is called in other thread.
Comment 1 Víctor Manuel Jáquez Leal 2016-10-27 16:17:09 UTC
Created attachment 338626 [details] [review]
plugins: ensure display when getting raw caps
Comment 2 Víctor Manuel Jáquez Leal 2016-11-04 12:58:02 UTC
Attachment 338626 [details] pushed as 9d5875d - plugins: ensure display when getting raw caps
Comment 3 Víctor Manuel Jáquez Leal 2016-11-04 13:09:05 UTC
this patch should be back ported to 1.10