After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773512 - rtph263pay: Fix leak for B-fragments
rtph263pay: Fix leak for B-fragments
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 773514
 
 
Reported: 2016-10-26 07:58 UTC by Stian Selnes (stianse)
Modified: 2016-11-04 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtph263pay: Fix leak for B-fragments (2.66 KB, patch)
2016-10-26 07:58 UTC, Stian Selnes (stianse)
committed Details | Review

Description Stian Selnes (stianse) 2016-10-26 07:58:22 UTC
Altough commits 6a16be7, 64f9d08 and 0c7e3a8 fixed some issues they
introduced others. This patch fixes the leak of one macroblock for every
B fragment.

Macroblock structures must not be freed immediately after finding the
boundaries as they are stored and used later. However the inital dummy
structure (used for finding the first boundary) must be freed.

CID #1212156
Comment 1 Stian Selnes (stianse) 2016-10-26 07:58:27 UTC
Created attachment 338478 [details] [review]
rtph263pay: Fix leak for B-fragments
Comment 2 Sebastian Dröge (slomo) 2016-11-01 18:18:24 UTC
Attachment 338478 [details] pushed as bcff182 - rtph263pay: Fix leak for B-fragments