After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773511 - flvdemux: Make "no-more-pads-threshold" a property
flvdemux: Make "no-more-pads-threshold" a property
Status: RESOLVED DUPLICATE of bug 764260
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-26 07:54 UTC by Stian Selnes (stianse)
Modified: 2017-01-16 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flvdemux: Make "no-more-pads-threshold" a property (5.25 KB, patch)
2016-10-26 07:54 UTC, Stian Selnes (stianse) 		reviewed Details | Review

Description Stian Selnes (stianse) 2016-10-26 07:54:44 UTC 
Allows it to be configured differently for different use-cases,
specifically the live scenario would probably never want this enabled.
Comment 1 Stian Selnes (stianse) 2016-10-26 07:54:50 UTC 
Created attachment 338477 [details] [review]
flvdemux: Make "no-more-pads-threshold" a property
Comment 2 Sebastian Dröge (slomo) 2016-10-26 08:11:25 UTC 
Review of attachment 338477 [details] [review]:

This should be solved in a better way IMHO, that is with the new GstStreams API, adding/removing pads whenever we want and playbin3/decodebin3 handling that.

::: gst/flv/gstflvdemux.c
@@ +91,3 @@
+enum
+{
+  PROP_00, /* PROP_0 already used by included gstindex.c */

PROP_0 (== 0) is also not a valid GObject property index

@@ +3648,3 @@
+
+  g_object_class_install_property (gobject_class, PROP_NO_MORE_PADS_THRESHOLD,
+      g_param_spec_int64 ("no-more-pads-threshold", "No-More-Pads Threshold",

Why signed? GstClockTime is unsigned, and default would be GST_CLOCK_TIME_NONE, i.e. unsigned
Comment 3 Tim-Philipp Müller 2016-10-26 09:17:08 UTC 
I have a feeling we WONTFIXed this in the past :)
Comment 4 Sebastian Dröge (slomo) 2016-10-26 09:22:49 UTC 
Yes, having properties on demuxers is usually not very useful...
Comment 5 Sebastian Dröge (slomo) 2017-01-16 14:41:44 UTC 
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 764260 ***