After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773462 - Color Picker should support range regardless of image color precision
Color Picker should support range regardless of image color precision
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal enhancement
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-10-25 08:26 UTC by BugsBunny
Modified: 2017-01-03 00:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description BugsBunny 2016-10-25 08:26:29 UTC
I would like the color picker to let me choose which range it will show the values in regardless of the image's color precision.
i.e. I may want to see % when working on an 8-bit image, or I may want to see colors in the 0-255 range when working on a 32-bit floating point image.
Comment 1 Jehan 2016-12-20 03:47:34 UTC
Hello,

> i.e. I may want to see % when working on an 8-bit image

You can already see % (selecting "RGB"). This value does not change for a pixel, whether you are on 8, 26, 32… bit.

> I may want to see colors in the 0-255 range when working on a 32-bit floating point image.

What is the use case exactly? I am always a little wary of adding new options (buttons, sliders, knobs everywhere!) just because we can.

The "Pixel" values show what value is really saved in the pixel (without adding semantic). Showing a 0-255 range for 32-bit is therefore some kind of color conversion. Not sure this is really desired.
Comment 2 BugsBunny 2016-12-20 15:33:21 UTC
Hi Jehan

Use cases:
- To compare with values from other programs which only support 0-255,
- To target colorchecker values which are only in Lab or 0-255,
- To follow online guides but in a higher precision than the the guide was written for,
- To set colors from online pallets/swatches but in a higher precision,
- To work in higher precision while intending to save the final result to 8-bit.

We were asked for adding this to RawTherapee a bunch of times, finally added it and made people happy.
Comment 3 Jehan 2016-12-23 01:44:45 UTC
Adding a reference to bug 118166 where it was proposed to enter color with various ranges.
Comment 4 Michael Natterer 2017-01-01 18:33:43 UTC
I just hacked this up and it indeed feels quite useful. Just have
to agree with myself on a label before pushing...
Comment 5 Michael Natterer 2017-01-03 00:24:45 UTC
Fixed in master, now we need the same for entering colors
in the color selectors...

commit 237d83dc7fdbe758a61fb2047a9953f9a7f79213
Author: Michael Natterer <mitch@gimp.org>
Date:   Tue Jan 3 01:20:30 2017 +0100

    Bug 773462 - Color Picker should support range...
    
    ...regardless of image color precision
    
    Split enum value GIMP_COLOR_FRAME_MODE_RGB into RGB_PERCENT and RGB_U8,
    which display the current % values, and values in a range of 0..255.

 app/display/gimpcursorview.c    |  2 +-
 app/tools/gimpcolorpickertool.c |  2 +-
 app/widgets/gimpcolorframe.c    | 34 +++++++++++++++++++++-------------
 app/widgets/widgets-enums.c     |  6 ++++--
 app/widgets/widgets-enums.h     |  9 +++++----
 5 files changed, 32 insertions(+), 21 deletions(-)