After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773422 - net: Always return an error on failure
net: Always return an error on failure
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-24 14:32 UTC by Bastien Nocera
Modified: 2016-10-24 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
net: Downgrade verbose error output to a GRL_DEBUG() (856 bytes, patch)
2016-10-24 14:32 UTC, Bastien Nocera 		committed Details | Review
net: Always return an error on failure (967 bytes, patch)
2016-10-24 14:32 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-10-24 14:32:03 UTC 
.
Comment 1 Bastien Nocera 2016-10-24 14:32:07 UTC 
Created attachment 338349 [details] [review]
net: Downgrade verbose error output to a GRL_DEBUG()

And don't mark debug strings as translatable.
Comment 2 Bastien Nocera 2016-10-24 14:32:13 UTC 
Created attachment 338350 [details] [review]
net: Always return an error on failure

When getting a "Gateway timeout" error, or any other errors not handled
in the switch statement, we should make sure to return an error.
Comment 3 Victor Toso 2016-10-24 14:35:49 UTC 
Review of attachment 338349 [details] [review]:

sure
Comment 4 Victor Toso 2016-10-24 14:36:18 UTC 
Review of attachment 338350 [details] [review]:

ok
Comment 5 Bastien Nocera 2016-10-24 14:52:48 UTC 
Attachment 338349 [details] pushed as cd58c04 - net: Downgrade verbose error output to a GRL_DEBUG()
Attachment 338350 [details] pushed as b424544 - net: Always return an error on failure