After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773344 - glib-compile-resources: Fix creating depfile with other targets
glib-compile-resources: Fix creating depfile with other targets
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-10-22 07:59 UTC by Patrick Griffis (tingping)
Modified: 2016-10-24 05:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glib-compile-resources: Fix creating depfile with other targets (4.87 KB, patch)
2016-10-22 07:59 UTC, Patrick Griffis (tingping)
committed Details | Review

Description Patrick Griffis (tingping) 2016-10-22 07:59:24 UTC
Created attachment 338248 [details] [review]
glib-compile-resources: Fix creating depfile with other targets

The --dependency-file argument could not be ran with other targets as it should with commit 87d76a5a9cadb059b9dc434af469a28f5ede7544 from bug 745754.
Comment 1 Matthias Clasen 2016-10-23 23:42:38 UTC
Review of attachment 338248 [details] [review]:

I haven't checked this line-by-line, but it looks right
Comment 2 Patrick Griffis (tingping) 2016-10-24 05:49:16 UTC
Attachment 338248 [details] pushed as 243c1b7 - glib-compile-resources: Fix creating depfile with other targets