GNOME Bugzilla – Bug 773208
vp9: Add support for 10 bit and other subsampling / alpha
Last modified: 2018-11-03 15:13:03 UTC
See summary
Created attachment 372781 [details] [review] vp9dec: Add support 10/12 bit depth decoding libvpx's high bitdepth (10 or 12 bit depth) formats are supported by Gstreamer already
I tested a sample which was provided by google at https://developers.google.com/media/vp9/hdr-encoding/ And it works well (if libvpx was built with --enable-vp9-highbitdepth option)
A question is that we've been using mapping of libav's AV_PIX_FMT_YUV420P10LE to GST_VIDEO_FORMAT_I420_10LE but it seems to incorrect, since the decoding result of this file using avdec_vp9 causes broken video frame (when it is rendered). https://storage.googleapis.com/media.webmproject.org/devsite/vp9/output/hdr/2pass_HDR_strobe_scientist_6Mbps-static.webm (AV_PIX_FMT_YUV420P10BE, AV_PIX_FMT_YUV422P10LE, AV_PIX_FMT_YUV422P10BE, AV_PIX_FMT_YUV444P10LE, AV_PIX_FMT_YUV444P10BE) seems to also incorrectly mapped. So, I guess above FFMPEG formats might be unsupported format by Gstreamer. Instead, mapping AV_PIX_FMT_YUV420P16LE with GST_VIDEO_FORMAT_I420_10LE seems correct.
I haven't looked, but P10 sounds like Microsoft P010, an nv12 variant. 16bit packed. That would match GST_VIDEO_FORMAT_P010_10LE.
(In reply to Nicolas Dufresne (ndufresne) from comment #4) > I haven't looked, but P10 sounds like Microsoft P010, an nv12 variant. 16bit > packed. That would match GST_VIDEO_FORMAT_P010_10LE. Thanks. AV_PIX_FMT_YUV420P10BE seems to be matched with GST_VIDEO_FORMAT_P010_10BE, and when I modified to do that, I can see correct rendering.
Created attachment 372827 [details] [review] [1/3] vpxenc: Report image format setting error Some image format could not be supported by libvpx
Created attachment 372828 [details] [review] [2/3] vp9enc: Add support 10/12bit encoding
Created attachment 372829 [details] [review] [3/3] vp9enc: Add support 10/12bit encoding
I tested with my patch set and it seems to work well (en/decoding) for new video formats
Created attachment 372830 [details] [review] [3/3] vp9dec: Add support 10/12bit decoding
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/310.