After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773116 - Plug a couple of leaks
Plug a couple of leaks
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-17 17:17 UTC by Rui Matos
Modified: 2016-10-18 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaMonitorManageKms: plug a GArray leak (1.68 KB, patch)
2016-10-17 17:17 UTC, Rui Matos 		committed Details | Review
MetaRendererNative: don't call drmModeGetResources() (1.66 KB, patch)
2016-10-17 17:17 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-10-17 17:17:46 UTC 
Spotted while doing other stuff.
Comment 1 Rui Matos 2016-10-17 17:17:50 UTC 
Created attachment 337879 [details] [review]
MetaMonitorManageKms: plug a GArray leak
Comment 2 Rui Matos 2016-10-17 17:17:55 UTC 
Created attachment 337880 [details] [review]
MetaRendererNative: don't call drmModeGetResources()

There's no need to call this and we were leaking the returned memory.
Comment 3 Florian Müllner 2016-10-17 17:32:05 UTC 
Review of attachment 337880 [details] [review]:

OK
Comment 4 Florian Müllner 2016-10-17 17:32:09 UTC 
Review of attachment 337879 [details] [review]:

OK
Comment 5 Rui Matos 2016-10-18 12:25:47 UTC 
Attachment 337879 [details] pushed as 89672fa - MetaMonitorManageKms: plug a GArray leak
Attachment 337880 [details] pushed as 8290e1f - MetaRendererNative: don't call drmModeGetResources()