After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773007 - GtkFilechooser gives completion for non-matching extensions
GtkFilechooser gives completion for non-matching extensions
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-10-16 01:32 UTC by Mohammed Sadiq
Modified: 2016-11-18 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
File chooser completion (image) (56.16 KB, image/png)
2016-10-16 01:32 UTC, Mohammed Sadiq 		  Details
filechooserwidget: Forward file filter to entry (7.47 KB, patch)
2016-11-15 10:04 UTC, Timm Bäder 		accepted-commit_now Details | Review

Description Mohammed Sadiq 2016-10-16 01:32:57 UTC 
Created attachment 337775 [details]
File chooser completion (image)

GtkFilechooser name completion lists files of non-matching extensions.

Say for example, the attached screenshot is from GNOME calendar, that asks me to select calendar files (.ics). When I type some letter, all the matching files in the directory is offered as completion, even when it isn't a calendar file.

Ideally, it shouldn't list non-compatible files.

Thanks
Comment 1 Timm Bäder 2016-11-15 10:04:40 UTC 
Created attachment 339906 [details] [review]
filechooserwidget: Forward file filter to entry
Comment 2 Matthias Clasen 2016-11-17 13:11:07 UTC 
Review of attachment 339906 [details] [review]:

Makes sense to me.
Comment 3 Timm Bäder 2016-11-18 09:04:35 UTC 
I pushed that patch as 55fda57c44ab90380a92ec36518d572b7d7992b8.