After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772756 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks: 772263
 
 
Reported: 2016-10-11 13:33 UTC by Piotr Drąg
Modified: 2016-10-11 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use Unicode in translatable strings (10.38 KB, patch)
2016-10-11 13:33 UTC, Piotr Drąg
none Details | Review
Use Unicode in translatable strings (9.70 KB, patch)
2016-10-11 14:35 UTC, Piotr Drąg
committed Details | Review

Description Piotr Drąg 2016-10-11 13:33:47 UTC
Created attachment 337433 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Philip Withnall 2016-10-11 14:05:56 UTC
Review of attachment 337433 [details] [review]:

::: gdata/services/documents/gdata-documents-document.c
@@ -399,3 @@
 	if (download_uri == NULL) {
 		g_set_error (error, GDATA_SERVICE_ERROR, GDATA_SERVICE_ERROR_NOT_FOUND,
-		             _("Unknown or unsupported document export format ‘%s’."), export_format);

That one’s already Unicode. Please don’t change the single quotes to double quotes.

::: gdata/services/documents/gdata-documents-service.c
@@ +944,3 @@
 	if (g_type_is_a (new_document_type, GDATA_TYPE_DOCUMENTS_DOCUMENT) == FALSE) {
 		g_set_error (error, GDATA_DOCUMENTS_SERVICE_ERROR, GDATA_DOCUMENTS_SERVICE_ERROR_INVALID_CONTENT_TYPE,
+		             _("The content type of the supplied document (“%s”) could not be recognized."),

Please use single Unicode quotes.

::: gdata/services/freebase/gdata-freebase-service.c
@@ +477,3 @@
 			     GDATA_SERVICE_ERROR,
 			     GDATA_SERVICE_ERROR_BAD_QUERY_PARAMETER,
+			     _("Property “%s” does not hold an image"),

Please use single Unicode quotes.

This comment applies throughout the patch; even for the ones which were originally double ASCII quotes — let’s use this opportunity to standardise libgdata on single quotes.

The HIG page doesn’t actually specify whether double or single quotes should be used, it just specifies that double Unicode quotes should be used instead of double ASCII quotes.
Comment 2 Piotr Drąg 2016-10-11 14:35:13 UTC
Created attachment 337442 [details] [review]
Use Unicode in translatable strings
Comment 3 Philip Withnall 2016-10-11 15:43:41 UTC
Review of attachment 337442 [details] [review]:

Great, thanks. Please push to master.
Comment 4 Piotr Drąg 2016-10-11 15:53:20 UTC
Comment on attachment 337442 [details] [review]
Use Unicode in translatable strings

Pushed, thank you.