After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772723 - osdWindow: relayout when scale factor changes
osdWindow: relayout when scale factor changes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-11 00:02 UTC by Cosimo Cecchi
Modified: 2016-10-11 00:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
osdWindow: relayout when scale factor changes (1.82 KB, patch)
2016-10-11 00:02 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-10-11 00:02:54 UTC 
See attached patch, which fixes a long-term annoyance of the OSD window with HiDpi.
Comment 1 Cosimo Cecchi 2016-10-11 00:02:59 UTC 
Created attachment 337380 [details] [review]
osdWindow: relayout when scale factor changes

We currently rely on the "monitors-changed" signal of LayoutManager to
relayout the OSD window. That is not enough, since the scale factor also
changes the way the OSD window is sized, and that can be updated after
"monitors-changed" has been received.
The visual effect is that under some circumstances, the OSD window will
have the wrong size under HiDpi.

This commit fixes the issue by triggering another relayout when the
scale factor changes.
Comment 2 Florian Müllner 2016-10-11 00:14:06 UTC 
Review of attachment 337380 [details] [review]:

LGTM
Comment 3 Cosimo Cecchi 2016-10-11 00:25:24 UTC 
Attachment 337380 [details] pushed as 4670db6 - osdWindow: relayout when scale factor changes