After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772704 - hlsdemux: fix GstHLSDemuxStream type inheritance
hlsdemux: fix GstHLSDemuxStream type inheritance
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.10.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-10 14:56 UTC by Arnaud Vrac
Modified: 2016-10-31 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
hlsdemux: fix stream type inheritance (1009 bytes, patch)
2016-10-10 14:56 UTC, Arnaud Vrac 		committed Details | Review

Description Arnaud Vrac 2016-10-10 14:56:32 UTC 
Created attachment 337328 [details] [review]
hlsdemux: fix stream type inheritance

Obvious but hard to find by debugging :)
Comment 1 Tim-Philipp Müller 2016-10-11 08:57:53 UTC 
oops, nicely spotted, thanks!

commit e2dea99dc95d99f7f84ec7b82c486f420163d0e6
Author: Arnaud Vrac <avrac@freebox.fr>
Date:   Mon Oct 10 16:52:58 2016 +0200

    hlsdemux: fix hls demux stream type inheritance
    
    GstHLSDemuxStream inherits GstAdaptiveDemuxStream, not
    GstAdaptiveDemux. Fixes memory corruption issues.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772704
Comment 2 GstBlub 2016-10-12 14:56:07 UTC 
Review of attachment 337328 [details] [review]:

Was the change to common intended?
Comment 3 Tim-Philipp Müller 2016-10-12 17:22:03 UTC 
> Was the change to common intended?

Nope, thanks for spotting!

commit ff579a7c8f271329aabaa6b40e753903e8b945d4
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Wed Oct 12 18:20:27 2016 +0100

    common: sync to latest revision
    
    Fixes accidental common change when commit patch.