Created attachment 349373 [details] [review]
Use Unicode in translatable strings

Rebased on current master.

Review of attachment 349373 [details] [review]:

I'm fine with U+201C and U+201D quotation mark changes but I don't think the range ones (U+201D) are correct, are they?
In the commit log I would include that we are changing "..." to “...” just to make it even clear.

PS: Doing grep -rnIi "_(.*)" * | grep -i "\"" did not find any other occurrence.

::: src/magnatune/grl-magnatune.c
@@ +450,3 @@
       err = g_error_new(GRL_CORE_ERROR,
                         GRL_CORE_ERROR_MEDIA_NOT_FOUND,
+                        _("Failed to save database from magnatune — “%s”"),

Not a range

::: src/tracker/grl-tracker-utils.c
@@ +736,3 @@
         gchar *m_name = g_mount_get_name (G_MOUNT (mount->data));
         g_object_unref (G_OBJECT (m_file));
+        source_name = g_strdup_printf (_("Removable — %s"), m_name);

Not a range

@@ +757,3 @@
 get_tracker_upnp_name (const gchar *datasource_name)
 {
+  return g_strdup_printf ("UPnP — %s", datasource_name);

Not a range

Created attachment 351002 [details] [review]
Use Unicode in translatable strings

This is not the en-dash used for ranges, it’s the conclusive em-dash, used similarly to a colon. I forgot it’s not in HIG yet, but it was in the draft (https://wiki.gnome.org/Design/OS/Typography) and it is a part of proper English typography.

I propose to use the em-dash in the last two strings, and replace it with a colon in the first string. It would fit other strings in the file that also use colons.

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/103.