After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772488 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 772263
 
 
Reported: 2016-10-06 00:17 UTC by Piotr Drąg
Modified: 2017-02-14 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
color: use Unicode in translatable strings (1.68 KB, patch)
2016-10-06 00:18 UTC, Piotr Drąg 		needs-work Details | Review
peripherals: use Unicode in translatable strings (3.49 KB, patch)
2016-10-06 00:19 UTC, Piotr Drąg 		committed Details | Review
plugins: use Unicode in translatable strings (1.16 KB, patch)
2016-10-06 00:20 UTC, Piotr Drąg 		none Details | Review
print-notifications: use Unicode in translatable strings (13.76 KB, patch)
2016-10-06 00:21 UTC, Piotr Drąg 		committed Details | Review
wacom: use Unicode in translatable strings (2.17 KB, patch)
2016-10-06 00:21 UTC, Piotr Drąg 		none Details | Review
xrandr: use Unicode in translatable strings (2.75 KB, patch)
2016-10-06 00:21 UTC, Piotr Drąg 		committed Details | Review
xsettings: use Unicode in translatable strings (3.89 KB, patch)
2016-10-06 00:21 UTC, Piotr Drąg 		committed Details | Review
wacom: use Unicode in translatable strings (1.29 KB, patch)
2017-02-11 13:13 UTC, Piotr Drąg 		committed Details | Review
plugins: use Unicode in translatable strings (1.15 KB, patch)
2017-02-14 15:20 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2016-10-06 00:17:56 UTC 
Attached patches convert ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Piotr Drąg 2016-10-06 00:18:30 UTC 
Created attachment 337020 [details] [review]
color: use Unicode in translatable strings
Comment 2 Piotr Drąg 2016-10-06 00:19:03 UTC 
Created attachment 337021 [details] [review]
peripherals: use Unicode in translatable strings
Comment 3 Piotr Drąg 2016-10-06 00:20:46 UTC 
Created attachment 337022 [details] [review]
plugins: use Unicode in translatable strings
Comment 4 Piotr Drąg 2016-10-06 00:21:04 UTC 
Created attachment 337023 [details] [review]
print-notifications: use Unicode in translatable strings
Comment 5 Piotr Drąg 2016-10-06 00:21:20 UTC 
Created attachment 337024 [details] [review]
wacom: use Unicode in translatable strings
Comment 6 Piotr Drąg 2016-10-06 00:21:37 UTC 
Created attachment 337025 [details] [review]
xrandr: use Unicode in translatable strings
Comment 7 Piotr Drąg 2016-10-06 00:21:53 UTC 
Created attachment 337026 [details] [review]
xsettings: use Unicode in translatable strings
Comment 8 Piotr Drąg 2017-02-11 13:13:59 UTC 
Created attachment 345517 [details] [review]
wacom: use Unicode in translatable strings

Rebased on master.
Comment 9 Bastien Nocera 2017-02-11 14:00:36 UTC 
Attachment 337023 [details] pushed as a7ea663 - print-notifications: use Unicode in translatable strings
Attachment 337025 [details] pushed as c4a349c - xrandr: use Unicode in translatable strings
Attachment 337026 [details] pushed as aa989a7 - xsettings: use Unicode in translatable strings
Attachment 345517 [details] pushed as 02b2a6b - wacom: use Unicode in translatable strings
Comment 10 Bastien Nocera 2017-02-11 14:02:31 UTC 
Comment on attachment 337020 [details] [review]
color: use Unicode in translatable strings

Doesn't apply any more.
Comment 11 Bastien Nocera 2017-02-11 14:02:51 UTC 
Comment on attachment 337022 [details] [review]
plugins: use Unicode in translatable strings

Ditto.
Comment 12 Piotr Drąg 2017-02-11 14:11:39 UTC 
(In reply to Bastien Nocera from comment #10)
> Comment on attachment 337020 [details] [review] [review]
> color: use Unicode in translatable strings
> 
> Doesn't apply any more.

It looks like you already pushed it: https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=c01cfff2815677f057755a82e0dd64499a30da78

(In reply to Bastien Nocera from comment #11)
> Comment on attachment 337022 [details] [review] [review]
> plugins: use Unicode in translatable strings
> 
> Ditto.

Are you sure? It applies cleanly here.
Comment 13 Piotr Drąg 2017-02-14 15:20:34 UTC 
Created attachment 345740 [details] [review]
plugins: use Unicode in translatable strings

Rebased on current master.
Comment 14 Bastien Nocera 2017-02-14 17:58:43 UTC 
Comment on attachment 337020 [details] [review]
color: use Unicode in translatable strings

Was committed in c01cfff2815677f057755a82e0dd64499a30da78