After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772464 - Test suite fails if run in parallel
Test suite fails if run in parallel
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
1.4.x
Other Linux
: Normal major
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-05 17:36 UTC by Michael Biebl
Modified: 2016-10-06 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Biebl 2016-10-05 17:36:09 UTC
If the network-manager-openvpn build is run with make -j 4 , it fails
The problem is that test-import-export and test-import-export-glib are run in parallel and they use the same tmp directory which is hard-coded to
#define TMPDIR TEST_BUILDDIR"/conf-tmp"

So there is a race and it's possible that they unlink files from the other running process

We should use something like g_mkdtemp() instead, which ensures we have a unique directory per process.
Comment 1 Thomas Haller 2016-10-05 17:44:48 UTC
I assume you mean nm-openvpn? Because nm-openconnect has no unit tests...
Comment 2 Thomas Haller 2016-10-05 17:45:19 UTC
ah, you even said it... just the component was wrong.
Comment 3 Michael Biebl 2016-10-05 17:48:02 UTC
Yes, I meant nm-openvpn. Sorry for the confusion.
We ran into this issue recently when I switching on support for building nm-openvpn in parallel.

See for example: https://buildd.debian.org/status/fetch.php?pkg=network-manager-openvpn&arch=amd64&ver=1.2.6-1&stamp=1475604711
Comment 5 Michael Biebl 2016-10-05 18:07:17 UTC
Thomas, can we clone this bug for network-manager-vpnc as well?
See https://buildd.debian.org/status/fetch.php?pkg=network-manager-vpnc&arch=amd64&ver=1.2.4-1&stamp=1475606016
Comment 6 Thomas Haller 2016-10-06 11:54:58 UTC
fixed in master: https://git.gnome.org/browse/network-manager-openvpn/commit/?id=94499b2d6203ec321b1417369278ca3cebe0c401


nm-vpnc (bug 772471) follows...



Thanks for reporting!