GNOME Bugzilla – Bug 772406
Unit test for compounds/dashes fails with aspell
Last modified: 2017-03-24 13:39:46 UTC
Created attachment 336901 [details] Build log Hello, During the build of gspell 1.2.0, I'm getting the following error: ERROR:test-checker.c:106:test_dashes: assertion failed: (correctly_spelled) With 1.0.3 the tests are passing fine
It tries to spell check "spell-checking", and the unit test assumes it is correctly spelled, but maybe not all Enchant backend returns the same result. Which Enchant backend is used? The unit test can be modified with another compound. See: https://en.wikipedia.org/wiki/English_compound
OK in my build chroot I didn't had hunspell-en-us package (which contains /usr/share/hunspell/en_US.dic) installed, so it seems that it was relying on aspell for the test and this was failing. As soon as I install the hunspell english dictionary, the test succeed
I can look at how to make all unit tests pass with both hunspell or aspell. I tested only with hunspell. Anyway if the unit test for compounds doesn't pass, it is not a big problem (the applications won't crash), it's just that compounds will be marked as misspelled.
(In reply to Sébastien Wilmet from comment #1) > The unit test can be modified with another compound. See: > https://en.wikipedia.org/wiki/English_compound It seems that aspell-en doesn't support compounds with dashes. I've tried all these compounds: - blue-green - over-ripe - freeze-dry - love-in - salt-and-pepper All those compounds are marked as correctly spelled with hunspell, and all of them are marked as misspelled with aspell. Anyway I think aspell can be considered deprecated, at least for the English language. hunspell is preferred. See those old initiatives: https://fedoraproject.org/wiki/Releases/FeatureDictionary https://wiki.ubuntu.com/ConsolidateSpellingLibs So I'll close this bug as WONTFIX, it is not worth adding conditional code in gspell depending on the enchant backend, especially for a deprecated backend.