After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772357 - srtpdec: add stats readonly property
srtpdec: add stats readonly property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-03 08:53 UTC by Vincent Penquerc'h
Modified: 2016-11-01 17:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
srtpdec: add stats readonly property (2.67 KB, patch)
2016-10-03 08:54 UTC, Vincent Penquerc'h 		committed Details | Review
unit test for this (and basic srtp playback) (8.76 KB, patch)
2016-10-04 16:00 UTC, Vincent Penquerc'h 		none Details | Review
unit test for this (and basic srtp playback) (8.83 KB, patch)
2016-10-05 08:07 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2016-10-03 08:53:21 UTC 
srtpdec: add stats readonly property
Comment 1 Vincent Penquerc'h 2016-10-03 08:54:27 UTC 
Created attachment 336795 [details] [review]
srtpdec: add stats readonly property
Comment 2 Vincent Penquerc'h 2016-10-04 16:00:45 UTC 
Created attachment 336908 [details] [review]
unit test for this (and basic srtp playback)
Comment 3 Vincent Penquerc'h 2016-10-05 08:07:01 UTC 
Created attachment 336965 [details] [review]
unit test for this (and basic srtp playback)

Add ccu copyright, and remove stray + 8 I had in testing
Comment 4 Sebastian Dröge (slomo) 2016-10-20 10:52:23 UTC 
Comment on attachment 336795 [details] [review]
srtpdec: add stats readonly property

This looks like it needs some mutex :)
Comment 5 Vincent Penquerc'h 2016-10-20 14:10:51 UTC 
This is called between lock/unlock calls already. Do you mean something else ?
Comment 6 Sebastian Dröge (slomo) 2016-10-20 14:21:40 UTC 
Comment on attachment 336795 [details] [review]
srtpdec: add stats readonly property

No, I didn't see that get_property() is all locked in this case
Comment 7 Sebastian Dröge (slomo) 2016-11-01 17:38:11 UTC 
commit 9a2df5dc3b72470b2f7fdc7961be93a08bbc3971
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Oct 4 16:59:09 2016 +0100

    tests: add a test for srtp elements
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772357

commit d125d6b18c76703a4a067e2b961bb640c2094652
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Oct 3 09:52:07 2016 +0100

    srtpdec: add stats readonly property, similar to srtpenc
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772357