After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772335 - Duplicated tab with no history has Back button active
Duplicated tab with no history has Back button active
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Tabs
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-02 09:50 UTC by Jeremy Bicha
Modified: 2017-01-15 00:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window-commands: Duplicate tab should not alter back/forward list (2.34 KB, patch)
2017-01-15 00:41 UTC, Michael Catanzaro
committed Details | Review

Description Jeremy Bicha 2016-10-02 09:50:13 UTC
epiphany-browser 3.22.0-1ubuntu2
webkit2gtk 2.14.0-1
Ubuntu GNOME 16.04 Beta amd64

1. In GNOME Shell, open the Web app (epiphany).
2. Click the Web app menu and select Bookmarks.
3. Right click one of the Bookmarks and select Open in New Tab. (This tab has no history.)
4. Right click on the tab in the tab bar and select Duplicate.

What happens
============
The Duplicated tab has its Back button active. Clicking Back and then Forward shows the same page.

This is cumulative. Duplicating that tab will now have 3 of the same page in the new tab's history, etc.

Other info
==========
One suggested way to fix this is to not have the same page in consecutive locations in the history.

After looking at Epiphany a bit more, I see that opening a link on "Site Foo" in a new tab creates a new tab with all the history of the "Site Foo" tab. So I guess this is related to what's going on here. That behavior is a bit odd since I don't think any other mainstream browser does that (Firefox and Chromium at least don't). See bug 113694 where I guess that behavior was introduced.
Comment 1 Michael Catanzaro 2017-01-15 00:20:49 UTC
> After looking at Epiphany a bit more, I see that opening a link on "Site
> Foo" in a new tab creates a new tab with all the history of the "Site Foo"
> tab. So I guess this is related to what's going on here. That behavior is a
> bit odd since I don't think any other mainstream browser does that (Firefox
> and Chromium at least don't). See bug 113694 where I guess that behavior was
> introduced.

FYI: the behavior was lost in the WebKit2 port, and only restored quite recently, I think in 3.20. It's different than other browsers but it seems superior. There doesn't seem to be any advantage to not populating a new tab with the back/forward list from the parent tab, and before we restored this feature I was frequently annoyed when I was unable to go back to the page I opened the tab from. It's kinda related to this bug, indeed, but it's intentional, whereas the bug you've reported here is just a bug.
Comment 2 Michael Catanzaro 2017-01-15 00:41:43 UTC
The following fix has been pushed:
1b50480 window-commands: Duplicate tab should not alter back/forward list
Comment 3 Michael Catanzaro 2017-01-15 00:41:47 UTC
Created attachment 343486 [details] [review]
window-commands: Duplicate tab should not alter back/forward list

When we duplicate a tab, we don't want the new page load to appear in
the back/forward list. Do the same gymnastics with the list that
EphySession performs when restoring a web view.