GNOME Bugzilla – Bug 772284
The first user is always focused, resulting in multiple focused users
Last modified: 2017-07-13 17:45:01 UTC
Created attachment 336720 [details] GDM multiple focused users Hi, when there are multiple users on the system I experience the effect you can see in the attachment. The first user is always focused, and this results in having multiple focused users when hovering over other users. This does not seem to be related with the log-in status of the user: it happens also straight after boot, before any user logged in. (gnome-shell 3.22, but I cannot not select that in the version field in bugzilla.) Thanks, Antonio
(In reply to Antonio Ospite from comment #0) > The first user is always focused, and this results in having multiple > focused users when hovering over other users. The issue is simply that there is no visual difference between keyboard focus (that is, the user that gets activated when hitting enter) and hover.
(In reply to Florian Müllner from comment #1) > (In reply to Antonio Ospite from comment #0) > > The first user is always focused, and this results in having multiple > > focused users when hovering over other users. > > The issue is simply that there is no visual difference between keyboard > focus (that is, the user that gets activated when hitting enter) and hover. I see, and apparently the first user gets keyboard focus even if I never hit enter. Maybe the whole keyboard interaction could use some improvements, for example when going down with the arrow key I can get to the "Not listed?" item but its style does not change to indicate that it's become the active item. Thanks, Antonio
*** Bug 778295 has been marked as a duplicate of this bug. ***
Created attachment 353474 [details] [review] loginDialog: Only highlight a single item at any time The user list uses the same indication for hover and focus, so it is possible for two items to be highlighted at the same time. Using different styling would improve the situation, but only to some extent - the user would still need to figure out which highlight corresponds to which activation method. So instead, copy the approach we use in popup menus and use a single property for highlights that is updated by both focus- and hover changes.
Review of attachment 353474 [details] [review]: This makes most sense from the usability perspective.
does this mean enter right after boot is going to start picking a different user than it would now?
Good point, I'll have to test that.
(In reply to Ray Strode [halfline] from comment #6) > does this mean enter right after boot is going to start picking a different > user than it would now? At least on wayland the answer is no - the focus only moves after wiggling the mouse a bit.
okay seems fine to me then. I guess if we end up running into trouble down the road we can warp the pointer to the first item at start up.
Review of attachment 353474 [details] [review]: lgtm
Attachment 353474 [details] pushed as 526f2c8 - loginDialog: Only highlight a single item at any time
FWIW, I see one case there ::selected and activated item could go out of sync. If you hover user A, switch to user B with the keyboard and press the mouse button, it seems that user A would be activated while user B is highlighted. I guess the button pressed handler could do with another setSelected(true)