After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772253 - Fails to build with tzdata 2016g
Fails to build with tzdata 2016g
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: locations
unspecified
Other All
: High normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-30 12:53 UTC by Jeremy Bicha
Modified: 2016-12-22 15:08 UTC
See Also:
GNOME target: ---
GNOME version: 3.21/3.22


Attachments
data: Update Locations.xml for Rangoon>Yangon timezone name change (1.27 KB, patch)
2016-09-30 12:53 UTC, Jeremy Bicha
none Details | Review
data: Update Locations.xml for Rangoon>Yangon timezone name change (1.02 KB, patch)
2016-10-01 13:19 UTC, Jeremy Bicha
none Details | Review

Description Jeremy Bicha 2016-09-30 12:53:39 UTC
tzdata 2016g renamed [1] the Rangoon timezone to Yangon, causing libgweather 3.20.3 to fail to build.

How do you want to handle the translatable name field?

1. Just leave it as Rangoon.
2. Just change it to Yangon.
3. Branch the current git repo to gnome-3-20. Change it to Yangon. Backport the commit to the 3.20 series but without the Name change and do a 3.20.4 release.

Anyway, here's a patch that changes the name field too.

[1] https://launchpadlibrarian.net/287286222/tzdata_2016f-1_2016g-1.diff.gz
Comment 1 Jeremy Bicha 2016-09-30 12:53:42 UTC
Created attachment 336668 [details] [review]
data: Update Locations.xml for Rangoon>Yangon timezone name change
Comment 2 Bastien Nocera 2016-10-01 13:04:14 UTC
I wouldn't change the translatable name at all. From the Wikipedia page:
"
Soon after Burma's independence in 1948, many colonial names of streets and parks were changed to more nationalistic Burmese names. In 1989, the current military junta changed the city's English name to "Yangon", along with many other changes in English transliteration of Burmese names. (The changes have not been accepted by many Burmese who consider the junta unfit to make such changes, nor by many publications, news bureaux including, most notably, the BBC and foreign nations including the United Kingdom and United States.)
"

Languages where the translation is warranted probably already changed their translations.

There's a problem still. Can we detect the version of tzdata and make sure that we can only build against the newest version?
Comment 3 Jeremy Bicha 2016-10-01 13:11:43 UTC
> Can we detect the version of tzdata and make sure that we can only build against the newest version?

I don't think that's necessary because it's basically mandatory for distros to update tzdata promptly.
Comment 4 Bastien Nocera 2016-10-01 13:12:51 UTC
Detecting it early and erroring out would still be nice.
Comment 5 Jeremy Bicha 2016-10-01 13:19:48 UTC
Created attachment 336727 [details] [review]
data: Update Locations.xml for Rangoon>Yangon timezone name change

But don't change the Name field since that would affect translations
and Rangoon still appears to be the more common name in English
Comment 6 Jeremy Bicha 2016-10-01 13:20:39 UTC
That seems like it should be a separate issue since tzdata is not a normal library where checking its version is easy.
Comment 7 Jeremy Bicha 2016-10-15 18:03:47 UTC
Can this be merged and a new release made?
Comment 8 Giovanni Campagna 2016-12-22 15:08:09 UTC
Argh I had missed this bug, anyway I independently found and fixed the bug.

The fix is already in 3.20.4.