After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772191 - batch rename: tooltip not updated on change
batch rename: tooltip not updated on change
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-29 15:18 UTC by Mohammed Sadiq
Modified: 2016-10-04 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
batch-rename-dialog: Update tooltip on label change (2.19 KB, patch)
2016-10-03 08:38 UTC, Alexandru Pandelea 		none Details | Review
batch-rename-dialog: Update tooltip on label change (2.22 KB, patch)
2016-10-03 09:26 UTC, Alexandru Pandelea 		committed Details | Review

Description Mohammed Sadiq 2016-09-29 15:18:59 UTC 
The tooltip text on items doesn't get updated on change

How to reproduce:
1. Create some files
   touch 1 2
2. Select those -> Rename
3. Set template as '[Original file name][001, 002, 003]'
4. Hover over the new items (say 1001)

Result:
The tooltip still shows the old names (shows 1)

Expected result:
The tooltip should get updated on change of name (it should have shown 1001)
Comment 1 Alexandru Pandelea 2016-10-03 08:38:08 UTC 
Created attachment 336793 [details] [review]
batch-rename-dialog: Update tooltip on label change

The tooltip is not updated if the label will be changed.

To fix this, update the tooltip text each time the label changes.
Comment 2 Alexandru Pandelea 2016-10-03 09:26:11 UTC 
Created attachment 336797 [details] [review]
batch-rename-dialog: Update tooltip on label change

The tooltip is not updated if the label will be changed.

To fix this, update the tooltip text each time the label changes.
Comment 3 Carlos Soriano 2016-10-03 14:10:48 UTC 
Review of attachment 336797 [details] [review]:

ouch yes, idk why I accepted the other patch :(

Thanks!
Comment 4 Alexandru Pandelea 2016-10-04 09:53:17 UTC 
Attachment 336797 [details] pushed as a50f6e7 - batch-rename-dialog: Update tooltip on label change