Bug 771963 – GtkPaned warning in gtk_paned_realize

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 771963 - GtkPaned warning in gtk_paned_realize


Summary:	GtkPaned warning in gtk_paned_realize


Status:	RESOLVED FIXED

Product:	gtk+
Classification:	Platform
Component:	.General
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gtk-bugs
QA Contact:	gtk-bugs

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2016-09-25 22:29 UTC by Christian Hergert
Modified:	2016-09-29 15:58 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Christian Hergert 2016-09-25 22:29:54 UTC

We've seen these in other places, offender is:

  g_object_unref (attributes.cursor);

I just did a new jhbuild setup, so chances are I'm just missing a cursors package.

(gdb) bt

+ Trace 236701

#0 _g_log_abort
at /home/christian/Projects/glib/glib/gmessages.c line 487
#1 g_logv
at /home/christian/Projects/glib/glib/gmessages.c line 1296
#2 g_log
at /home/christian/Projects/glib/glib/gmessages.c line 1337
#3 g_return_if_fail_warning
#4 g_object_unref
at /home/christian/Projects/glib/gobject/gobject.c line 3082
#5 gtk_paned_realize
at /home/christian/Projects/gtk+/gtk/gtkpaned.c line 1705
#6 g_cclosure_marshal_VOID__VOIDv
at /home/christian/Projects/glib/gobject/gmarshal.c line 905
#7 g_type_class_meta_marshalv
at /home/christian/Projects/glib/gobject/gclosure.c line 1024
#8 _g_closure_invoke_va
at /home/christian/Projects/glib/gobject/gclosure.c line 867
#9 g_signal_emit_valist
at /home/christian/Projects/glib/gobject/gsignal.c line 3300
#10 g_signal_emit
at /home/christian/Projects/glib/gobject/gsignal.c line 3447
#11 gtk_widget_realize
at /home/christian/Projects/gtk+/gtk/gtkwidget.c line 5454
#12 gtk_widget_map
at /home/christian/Projects/gtk+/gtk/gtkwidget.c line 4984
#13 gtk_widget_set_child_visible
at /home/christian/Projects/gtk+/gtk/gtkwidget.c line 10727
#14 set_visible_child
at /home/christian/Projects/gtk+/gtk/gtkstack.c line 1130
#15 gtk_stack_set_visible_child_full
at /home/christian/Projects/gtk+/gtk/gtkstack.c line 1889
#16 gtk_stack_set_visible_child_name
at /home/christian/Projects/gtk+/gtk/gtkstack.c line 1839
#17 sp_window_set_state
at sp-window.c line 327
#18 sp_window_build_profile_cb
at sp-window.c line 224
#19 g_task_return_now
at /home/christian/Projects/glib/gio/gtask.c line 1121
#20 complete_in_idle_cb
at /home/christian/Projects/glib/gio/gtask.c line 1135
#21 g_idle_dispatch
at /home/christian/Projects/glib/glib/gmain.c line 5545
#22 g_main_dispatch
at /home/christian/Projects/glib/glib/gmain.c line 3203
#23 g_main_context_dispatch
at /home/christian/Projects/glib/glib/gmain.c line 3856
#24 g_main_context_iterate
at /home/christian/Projects/glib/glib/gmain.c line 3929
#25 g_main_context_iteration
at /home/christian/Projects/glib/glib/gmain.c line 3990
#26 g_application_run
at /home/christian/Projects/glib/gio/gapplication.c line 2381
#27 main
at sysprof.c line 35

Comment 1 Matthias Clasen 2016-09-26 15:19:10 UTC

That would be

     attributes.cursor = gdk_cursor_new_from_name (gtk_widget_get_display (widget),
                            priv->orientation == GTK_ORIENTATION_HORIZONTAL
                            ? "col-resize" : "row-resize")


failing. These are 'standard' cursor names, and the gdk backends will try fallbacks to ensure that you get a suitable cursor. So, you must be lacking any kind of decent cursor theme.

We could just swipe this under the rug by using g_clear_object

Comment 2 Christian Hergert 2016-09-27 18:19:18 UTC

I think that's what we've done in other places, which sounds good to me.

I've installed adwaita-icon-theme and gnome-themes-standard and I'm still seeing this in my jhbuild. Not exactly sure what other package I need to get.

Comment 3 Matthias Clasen 2016-09-27 18:51:58 UTC

adwaita-cursor-theme ?

Comment 4 Christian Hergert 2016-09-27 18:57:09 UTC

Unless I'm missing something, that is part of adwaita-icon-theme git/jhbuild module.

Comment 5 Matthias Clasen 2016-09-27 19:00:58 UTC

Yeah, not sure. We do have a test for the standard cursor names in 

testsuite/gtk/check-cursor-names

You could run that and see if it complains ?

Comment 6 Matthias Clasen 2016-09-27 19:01:21 UTC

I've now fixed the unref to be NULL-safe anyway