GNOME Bugzilla – Bug 771842
search-hit: port to use G_DECLARE* type declarations
Last modified: 2016-10-04 14:25:47 UTC
See bug 771777.
Created attachment 336834 [details] [review] Changed for G_DECLARE* Please review the patch. Tell me what other changes must be done. Thanks!
Review of attachment 336834 [details] [review]: LGTM except for a couple of things. ::: src/nautilus-search-hit.c @@ +386,2 @@ NAUTILUS_TYPE_SEARCH_HIT, + NautilusSearchHit); Mind the indentation here. ::: src/nautilus-search-hit.h @@ +28,1 @@ +#define NAUTILUS_TYPE_SEARCH_HIT (nautilus_search_hit_get_type ()) Avoid using tabs. A single space will do.
(In reply to Ernestas Kulik from comment #2) > LGTM except for a couple of things. And another one: you need a commit message to go with the patch. We have some guidelines to follow here: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines Thanks for working on this!
Created attachment 336835 [details] [review] Updated Patch Updated the patch.
Review of attachment 336835 [details] [review]: Looks good now, thanks!
Pushed to master, congrats!