After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771842 - search-hit: port to use G_DECLARE* type declarations
search-hit: port to use G_DECLARE* type declarations
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.21.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 771777
 
 
Reported: 2016-09-22 15:20 UTC by Ernestas Kulik
Modified: 2016-10-04 14:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Changed for G_DECLARE* (8.69 KB, patch)
2016-10-03 19:25 UTC, vinayakagarwal6996 		none Details | Review
Updated Patch (9.50 KB, patch)
2016-10-03 20:09 UTC, vinayakagarwal6996 		accepted-commit_now Details | Review

Description Ernestas Kulik 2016-09-22 15:20:56 UTC 
See bug 771777.
Comment 1 vinayakagarwal6996 2016-10-03 19:25:34 UTC 
Created attachment 336834 [details] [review]
Changed for G_DECLARE*

Please review the patch.
Tell me what other changes must be done.
Thanks!
Comment 2 Ernestas Kulik 2016-10-03 19:33:09 UTC 
Review of attachment 336834 [details] [review]:

LGTM except for a couple of things.

::: src/nautilus-search-hit.c
@@ +386,2 @@
                                                 NAUTILUS_TYPE_SEARCH_HIT,
+                                                NautilusSearchHit);

Mind the indentation here.

::: src/nautilus-search-hit.h
@@ +28,1 @@
+#define NAUTILUS_TYPE_SEARCH_HIT		(nautilus_search_hit_get_type ())

Avoid using tabs. A single space will do.
Comment 3 Ernestas Kulik 2016-10-03 19:38:43 UTC 
(In reply to Ernestas Kulik from comment #2)
> LGTM except for a couple of things.

And another one: you need a commit message to go with the patch.
We have some guidelines to follow here: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines

Thanks for working on this!
Comment 4 vinayakagarwal6996 2016-10-03 20:09:33 UTC 
Created attachment 336835 [details] [review]
Updated Patch

Updated the patch.
Comment 5 Carlos Soriano 2016-10-04 14:24:23 UTC 
Review of attachment 336835 [details] [review]:

Looks good now, thanks!
Comment 6 Carlos Soriano 2016-10-04 14:25:47 UTC 
Pushed to master, congrats!