After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771664 - [review] improve logging for nm-pptp VPN plugin [th/logging-bgo771664]
[review] improve logging for nm-pptp VPN plugin [th/logging-bgo771664]
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: pptp
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-09-19 15:42 UTC by Thomas Haller
Modified: 2017-09-26 08:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-09-19 15:42:06 UTC 
and various cleanups.
Comment 1 Beniamino Galvani 2016-09-20 09:48:41 UTC 
> service: add missing error handling when parsing command line

-   g_option_context_parse (opt_ctx, &argc, &argv, NULL);
+   if (!g_option_context_parse (opt_ctx, &argc, &argv, NULL)) {
+      g_printerr ("Error parsing the command line options: %s\n", error->message);

The @error parameter is missing in call to g_option_context_parse().

The rest LGTM.