After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771638 - Build without native backend fails
Build without native backend fails
Status: RESOLVED OBSOLETE
Product: mutter
Classification: Core
Component: wayland
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-18 23:33 UTC by Alexander Ried
Modified: 2021-07-05 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add the missing check (849 bytes, patch)
2016-09-18 23:33 UTC, Alexander Ried
accepted-commit_after_freeze Details | Review

Description Alexander Ried 2016-09-18 23:33:46 UTC
Created attachment 335823 [details] [review]
add the missing check

When trying to build without native backend, the build fails because of undefined macro META_IS_BACKEND_NATIVE in src/wayland/meta-wayland-keyboard.c:425. All other places this macro is used are guarded with an #ifdef HAVE_NATIVE_BACKEND.

The attached patch adds the missing ifdef.
Comment 1 Florian Müllner 2016-09-19 03:42:52 UTC
Review of attachment 335823 [details] [review]:

Yes
Comment 2 Jonas Ådahl 2016-09-19 03:49:53 UTC
(In reply to Florian Müllner from comment #1)
> Review of attachment 335823 [details] [review] [review]:
> 
> Yes

Not that it really matters, since there is currently little point to building mutter with the wayland backend but without the native backend, but the correct way would be to ifdef the whole function, since it should only do anything if the native backend is used.
Comment 3 Gilles Dartiguelongue 2016-11-08 08:10:54 UTC
Please note that building with wayland-backend enabled but native-backend disabled does not work either as reported in bug #772681.
Comment 4 GNOME Infrastructure Team 2021-07-05 13:50:18 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/mutter/-/issues/

Thank you for your understanding and your help.