Created attachment 335717 [details] [review]
power: Simplify update_automatic_suspend_label()

By replacing the magic 0 by its meaning ("never") as explained in the
gnome-settings-daemon GSettings schemas.

Created attachment 335718 [details] [review]
power: Warn if automatic suspend timeouts are negative

They should probably have been unsigned integers, but they're not, so
warn if they are. The rest of the code handles negative values as if
they were 0.

Review of attachment 335717 [details] [review]:

::: panels/power/cc-power-panel.c
@@ +1935,3 @@
 }
 
+#define NEVER 0

It's never unwise to #undef when you're done with it

(In reply to Michael Catanzaro from comment #3)
> Review of attachment 335717 [details] [review] [review]:
> 
> ::: panels/power/cc-power-panel.c
> @@ +1935,3 @@
>  }
>  
> +#define NEVER 0
> 
> It's never unwise to #undef when you're done with it

What does that help? It only adds more code.

Attachment 335717 [details] pushed as cc4e134 - power: Simplify update_automatic_suspend_label()
Attachment 335718 [details] pushed as 1abacd2 - power: Warn if automatic suspend timeouts are negative