After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771335 - Use generic signal marshallers
Use generic signal marshallers
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-13 00:29 UTC by Sam Thursfield
Modified: 2016-09-13 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove marshallers (62.88 KB, patch)
2016-09-13 00:29 UTC, Sam Thursfield 		committed Details | Review

Description Sam Thursfield 2016-09-13 00:29:18 UTC 
Since GLib 2.30 there is no need to generate custom marshalling functions for signal handlers. There is a generic libffi-based marshalling function now which can be used everywhere.

I've built Rhythmbox commit 1a85821ff72b with this patch, on Fedora 24, and tested that the resulting Rhythmbox binary can load itself and can play some music.
Comment 1 Sam Thursfield 2016-09-13 00:29:36 UTC 
Created attachment 335411 [details] [review]
Remove marshallers

GLib >= 2.30.0 adds g_cclosure_marshal_generic() which removes the need
for us to generate our own custom marshallers.
Comment 2 Jonathan Matthew 2016-09-13 12:15:01 UTC 
Review of attachment 335411 [details] [review]:

sure, why not
Comment 3 Jonathan Matthew 2016-09-13 12:16:28 UTC 
Thanks for doing this - I probably wasn't ever going to get around to it.