After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771288 - app window grows with each start due to incorrectly using gtk API (wayland)
app window grows with each start due to incorrectly using gtk API (wayland)
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: meld-maint
meld-maint
Depends on:
Blocks: WaylandRelated
 
 
Reported: 2016-09-12 11:59 UTC by Kamil Páral
Modified: 2016-09-16 23:07 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Kamil Páral 2016-09-12 11:59:47 UTC
Description of problem:
Since gtk3-3.21.5-1.fc25.x86_64 meld window grows with each start (on wayland). You can see the same issue with virt-manager here:
https://www.youtube.com/watch?v=NO6Wlaoq0x8
(the same issue applies to meld)

This has been reported against gtk:
https://bugzilla.gnome.org/show_bug.cgi?id=771112
and determined as an application bug:
https://bugzilla.gnome.org/show_bug.cgi?id=771112#c7

Quoting how to fix this:

~~~
https://wiki.gnome.org/HowDoI/SaveWindowState

Querying the window size and then setting it with GtkWindow API is perfectly fine.

Querying the window size with GtkWidget API and then setting it with GtkWindow API, *or* querying the window size with GtkWindow API and then setting it with GtkWidget API, is *not* okay, and only worked up until now with server-side decorations only on X11.
~~~

Version-Release number of selected component (if applicable):
meld-3.16.2-1.fc25.noarch
gtk3-3.21.5-1.fc25.x86_64

How reproducible:
always

Steps to Reproduce:
1. start and close meld repeatedly, it will grow each time
Comment 1 Kai Willadsen 2016-09-12 21:03:03 UTC
I'm sorry, since I realise that this isn't your problem, but... this is GTK+ API breakage. There's no way I'm "fixing" this in the stable Meld branch, and I definitely won't touch it until GTK+ is approaching stable.
Comment 2 Kamil Páral 2016-09-13 11:14:21 UTC
They claim the apps (like meld) have been broken for a long time, but it was not visible, because of xdg-shell v6. Or something like that, this is Greek to me. Could you perhaps talk to the gtk devs directly in bug 771112? Maybe you can convince them to put some countermeasures in. This definitely affects many applications.
Comment 3 Kai Willadsen 2016-09-16 23:07:59 UTC
Since GTK+ 3.22 is apparently actually going to be API stable maybe, I've now pushed a fix for this to the 3.16 branch and master. Thanks for the bug report.