After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771088 - decodebin3: Don't send duplicated stream-start event
decodebin3: Don't send duplicated stream-start event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.12.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-09 01:38 UTC by Seungha Yang
Modified: 2017-08-17 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch#1 (1.52 KB, patch)
2016-09-09 01:39 UTC, Seungha Yang 		committed Details | Review
dup_stream_start.log (5.25 KB, text/x-log)
2016-09-09 01:54 UTC, Seungha Yang 		  Details

Description Seungha Yang 2016-09-09 01:38:22 UTC 
decodebin3: Don't send duplicated stream-start event
 
group-id in stream-start event might be updated in
parse_chain_output_probe (). This cause duplicated stream-start
twice with identical stream-id and seq-num, but only group-id is
different. Although there is no change, stream-start event will
be followed by the first buffer.
Comment 1 Seungha Yang 2016-09-09 01:39:09 UTC 
Created attachment 335149 [details] [review]
patch#1
Comment 2 Seungha Yang 2016-09-09 01:54:09 UTC 
Created attachment 335150 [details]
dup_stream_start.log

Log for duplicated stream-start event.

It's tested by using following mpd
http://dash.akamaized.net/dash264/TestCases/5c/nomor/4_1a.mpd

And, current DASH demux has mult-period playback problem with playbin3,
patch at #Bug 768900 was applied.
Comment 3 Edward Hervey 2017-07-12 13:56:18 UTC 
After much digging in my git history and branches ... I can't remember why I added. Let's remove the event propagation in master and see how it fares.
Comment 4 Edward Hervey 2017-07-12 13:56:48 UTC 
Comment on attachment 335149 [details] [review]
patch#1

commit 06cf7440ce28d42768b0a980d67fc6f53c6cb7b9 (HEAD -> master, origin/master, origin/HEAD)
Author: Seungha Yang <sh.yang@lge.com>
Date:   Fri Sep 9 10:29:01 2016 +0900

    decodebin3: Don't send duplicated stream-start event
    
    group-id in stream-start event might be updated in
    parse_chain_output_probe (). This cause duplicated stream-start
    twice with identical stream-id and seq-num, but only group-id is
    different. Although there is no change, stream-start event will
    be followed by the first buffer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771088