After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771071 - batch-rename-dialog: clear some task data unconditionally
batch-rename-dialog: clear some task data unconditionally
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-08 17:25 UTC by Ernestas Kulik
Modified: 2016-09-08 18:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
batch-rename-dialog: clear some task data unconditionally (1.21 KB, patch)
2016-09-08 17:25 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2016-09-08 17:25:01 UTC 
destroy_conflicts_task_data() erroneously checks pointers to the mutex
and condition variables. They always evaluate to true and thus no
checking should be done in that case.
Comment 1 Ernestas Kulik 2016-09-08 17:25:06 UTC 
Created attachment 335133 [details] [review]
batch-rename-dialog: clear some task data unconditionally
Comment 2 Ernestas Kulik 2016-09-08 17:25:42 UTC 
My compiler spit out the warnings for those.
Comment 3 Ernestas Kulik 2016-09-08 17:30:52 UTC 
As the function already relies on the mutex not being locked and the condition variable not being blocked on by threads, we should also rely on them being initialized.
Comment 4 Carlos Soriano 2016-09-08 18:09:59 UTC 
Review of attachment 335133 [details] [review]:

LGTM thanks Ernestas!!
Comment 5 Ernestas Kulik 2016-09-08 18:11:31 UTC 
Attachment 335133 [details] pushed as e1c4119 - batch-rename-dialog: clear some task data unconditionally