After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771058 - The keyboard panel stopped working for a lot of shortcuts
The keyboard panel stopped working for a lot of shortcuts
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
: 771084 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-09-08 13:03 UTC by Florian Müllner
Modified: 2016-09-08 23:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Allow Tab in accels (2.70 KB, patch)
2016-09-08 13:03 UTC, Florian Müllner 		none Details | Review
keyboard: Remove additional filtering of default mod mask (1.66 KB, patch)
2016-09-08 13:03 UTC, Florian Müllner 		none Details | Review
keyboard: Allow Tab in accels (2.81 KB, patch)
2016-09-08 15:40 UTC, Bastien Nocera 		committed Details | Review
keyboard: Remove additional filtering of default mod mask (1.66 KB, patch)
2016-09-08 15:40 UTC, Bastien Nocera 		committed Details | Review
keyboard: Normalise Shift and Tab in shortcuts (2.32 KB, patch)
2016-09-08 15:40 UTC, Bastien Nocera 		committed Details | Review

Description Florian Müllner 2016-09-08 13:03:06 UTC 
I was pinged about this on IRC because gnome-shell's shortcut grabbing looked like an obvious suspect, but it turned out to be the panel itself disallowing any shortcuts that use the Super modifier or Tab keyval.

Unless we want to modify GTK+, the first patch (or something in its spirit) is correct. I'm less certain about the second patch, as that code was clearly added for some reason (unknown to myself).
Comment 1 Florian Müllner 2016-09-08 13:03:10 UTC 
Created attachment 335111 [details] [review]
keyboard: Allow Tab in accels

gtk_accelerator_valid() doesn't accept Tab as keyval, so using it to
check whether a shortcut is valid breaks commonly used shortcuts like
Alt+Tab. Unbreak those by adding a small wrapper that special-cases
Tab-with-modifiers.
Comment 2 Florian Müllner 2016-09-08 13:03:15 UTC 
Created attachment 335112 [details] [review]
keyboard: Remove additional filtering of default mod mask

The mask returned by gtk_accelerator_get_default_mod_mask() should
work without additional filtering, in particular when it is overly
restrictive - a lot of shortcuts use the Super modifier nowadays,
so stop filtering it out.
Comment 3 Bastien Nocera 2016-09-08 15:40:19 UTC 
Created attachment 335124 [details] [review]
keyboard: Allow Tab in accels

gtk_accelerator_valid() doesn't accept Tab as keyval, so using it to
check whether a shortcut is valid breaks commonly used shortcuts like
Alt+Tab. Unbreak those by adding a small wrapper that special-cases
Tab-with-modifiers.
Comment 4 Bastien Nocera 2016-09-08 15:40:27 UTC 
Created attachment 335125 [details] [review]
keyboard: Remove additional filtering of default mod mask

The mask returned by gtk_accelerator_get_default_mod_mask() should
work without additional filtering, in particular when it is overly
restrictive - a lot of shortcuts use the Super modifier nowadays,
so stop filtering it out.
Comment 5 Bastien Nocera 2016-09-08 15:40:33 UTC 
Created attachment 335126 [details] [review]
keyboard: Normalise Shift and Tab in shortcuts
Comment 6 Bastien Nocera 2016-09-08 15:41:11 UTC 
Attachment 335124 [details] pushed as 4beb7ce - keyboard: Allow Tab in accels
Attachment 335125 [details] pushed as 7896390 - keyboard: Remove additional filtering of default mod mask
Attachment 335126 [details] pushed as 45fb0a4 - keyboard: Normalise Shift and Tab in shortcuts
Comment 7 Bastien Nocera 2016-09-08 23:40:44 UTC 
*** Bug 771084 has been marked as a duplicate of this bug. ***