After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771035 - vaapiplugins: set updated image size to bufferpool on sink pad
vaapiplugins: set updated image size to bufferpool on sink pad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: 1.9.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-08 07:21 UTC by Hyunjun Ko
Modified: 2016-10-31 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugins: set allocator's image size to the bufferpool of sink pad (1.75 KB, patch)
2016-09-08 07:23 UTC, Hyunjun Ko 		none Details | Review
plugins: set allocator's image size to the bufferpool of sink pad (1.51 KB, patch)
2016-09-08 07:25 UTC, Hyunjun Ko 		committed Details | Review

Description Hyunjun Ko 2016-09-08 07:21:29 UTC 
This issue is mostly same as bug 769248.

Test pipeline:
gst-launch-1.0 videotestsrc ! video/x-raw,width=800,height=600 ! vaapisink

This leads to mismatch between bufferpool's set size and real allocated buffer size.
Comment 1 Hyunjun Ko 2016-09-08 07:23:00 UTC 
Created attachment 335063 [details] [review]
plugins: set allocator's image size to the bufferpool of sink pad
Comment 2 Hyunjun Ko 2016-09-08 07:25:47 UTC 
Created attachment 335064 [details] [review]
plugins: set allocator's image size to the bufferpool of sink pad
Comment 3 Víctor Manuel Jáquez Leal 2016-09-08 11:24:06 UTC 
Review of attachment 335064 [details] [review]:

::: gst/vaapi/gstvaapipluginbase.c
@@ +651,3 @@
     goto error_create_allocator;
+
+  gst_allocator_get_vaapi_image_size (plugin->sinkpad_allocator, &size);

Please initialize 'size' before, since gst_allocator_get_vaapi_image_size() might fail.

size = GST_VIDEO_INFO_SIZE (&vi);