After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770983 - Expand playing icon column in entry view
Expand playing icon column in entry view
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-07 03:26 UTC by gnome.vrb
Modified: 2016-09-11 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Expand playing icon column in entry view (674 bytes, patch)
2016-09-07 03:26 UTC, gnome.vrb
none Details | Review
Image depicting changes (165.80 KB, image/png)
2016-09-07 03:27 UTC, gnome.vrb
  Details
Let gtk choose optimal width (959 bytes, patch)
2016-09-07 04:46 UTC, gnome.vrb
committed Details | Review

Description gnome.vrb 2016-09-07 03:26:46 UTC
Created attachment 334952 [details] [review]
Expand playing icon column in entry view

The "audio-volume-high-symbolic" in first column header is short of space.
Comment 1 gnome.vrb 2016-09-07 03:27:28 UTC
Created attachment 334953 [details]
Image depicting changes
Comment 2 gnome.vrb 2016-09-07 03:31:59 UTC
Tried setting x padding to 0, as gtk library sets a compulsory padding of (2, 2) for few renderers ( text / toggle ). But it didn't work for pixbuf renderer. Increasing the column width by 5px worked.
Comment 3 gnome.vrb 2016-09-07 04:46:11 UTC
Created attachment 334955 [details] [review]
Let gtk choose optimal width

It appears that gtk handles this fine by default.
Comment 4 Jonathan Matthew 2016-09-11 09:16:39 UTC
Review of attachment 334955 [details] [review]:

pushed as commit e0a57e6 (without the added comment)