After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770692 - playbackutils: Move compare_factories_func
playbackutils: Move compare_factories_func
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 1.9.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-01 05:52 UTC by Wonchul Lee
Modified: 2016-09-30 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playbackutils: Move compare_factories_func (6.08 KB, patch)
2016-09-01 05:53 UTC, Wonchul Lee 		committed Details | Review

Description Wonchul Lee 2016-09-01 05:52:10 UTC 
_decode_bin_compare_factories_func is commonly used in decodebin2, uridecodebin and urisourcebi, so I moved it to the playbackutils.
Comment 1 Wonchul Lee 2016-09-01 05:53:03 UTC 
Created attachment 334583 [details] [review]
playbackutils: Move compare_factories_func
Comment 2 Sebastian Dröge (slomo) 2016-09-01 06:36:49 UTC 
Comment on attachment 334583 [details] [review]
playbackutils: Move compare_factories_func

Good to go after 1.9.2
Comment 3 Sebastian Dröge (slomo) 2016-09-01 06:37:25 UTC 
Review of attachment 334583 [details] [review]:

::: gst/playback/gstplaybackutils.h
@@ +34,3 @@
                                         gboolean isaudioelement);
+gint
+gst_playback_utils_compare_factories_func (gconstpointer p1, gconstpointer p2);

All the things in gstplaybackutils.h should get a G_GNUC_INTERNAL though. In another commit.
Comment 4 Sebastian Dröge (slomo) 2016-09-01 10:07:31 UTC 
commit 32aebd7baf774cf27c352b9c83f316622caf191e
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Sep 1 13:07:07 2016 +0300

    playback: Mark internal functions as G_GNUC_INTERNAL

commit 0cc3f199cac0f9b1803fffe8660aea299e7585ff
Author: Wonchul Lee <wonchul.lee@collabora.com>
Date:   Thu Sep 1 14:47:02 2016 +0900

    playbackutils: Move compare_factories_func
    
    Move _decode_bin_compare_factories_func function to playbackutils
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770692

Attachment 334583 [details] pushed as 0cc3f19 - playbackutils: Move compare_factories_func