After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770610 - daemon: Clean-up the memory management of our GKeyFile instances
daemon: Clean-up the memory management of our GKeyFile instances
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.21.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-08-30 18:25 UTC by Debarshi Ray
Modified: 2016-09-01 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
daemon, provider, utils: Use g_key_file_unref instead g_key_file_free (3.64 KB, patch)
2016-08-30 18:27 UTC, Debarshi Ray 		committed Details | Review
daemon: Let KeyFileData own a reference to the GKeyFile (1.07 KB, patch)
2016-08-30 18:27 UTC, Debarshi Ray 		committed Details | Review
daemon: Reduce one level of indentation (8.69 KB, patch)
2016-08-30 18:28 UTC, Debarshi Ray 		committed Details | Review
daemon: Consolidate exit paths & make the ref / unref more obvious (1.23 KB, patch)
2016-08-30 18:28 UTC, Debarshi Ray 		committed Details | Review
daemon: Remove the GList to track the GKeyFiles (2.83 KB, patch)
2016-08-30 18:28 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-08-30 18:25:11 UTC 
I think that we can get rid of key_files_to_free from src/daemon/goadaemon.c and clean-up some related code. See the attached patches.
Comment 1 Debarshi Ray 2016-08-30 18:27:08 UTC 
Created attachment 334465 [details] [review]
daemon, provider, utils: Use g_key_file_unref instead g_key_file_free
Comment 2 Debarshi Ray 2016-08-30 18:27:36 UTC 
Created attachment 334466 [details] [review]
daemon: Let KeyFileData own a reference to the GKeyFile
Comment 3 Debarshi Ray 2016-08-30 18:28:04 UTC 
Created attachment 334467 [details] [review]
daemon: Reduce one level of indentation
Comment 4 Debarshi Ray 2016-08-30 18:28:32 UTC 
Created attachment 334468 [details] [review]
daemon: Consolidate exit paths & make the ref / unref more obvious
Comment 5 Debarshi Ray 2016-08-30 18:28:57 UTC 
Created attachment 334469 [details] [review]
daemon: Remove the GList to track the GKeyFiles
Comment 6 Debarshi Ray 2016-09-01 14:53:09 UTC 
I am pushing these now so that they can get some testing as part of this week's 3.21.91 release. Please let me know if you notice something.