After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770578 - Remove NautilusEntry
Remove NautilusEntry
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-29 20:31 UTC by Ernestas Kulik
Modified: 2016-08-30 18:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove NautilusEntry (43.31 KB, patch)
2016-08-29 20:31 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2016-08-29 20:31:31 UTC
NautilusEntry was written to work around some issues with GtkEntry,
which are largely irrelevant, since its use has lessened over the years.
This commit removes the class.
Comment 1 Ernestas Kulik 2016-08-29 20:31:36 UTC
Created attachment 334404 [details] [review]
Remove NautilusEntry
Comment 2 Ernestas Kulik 2016-08-29 20:34:09 UTC
The latest uncrustify commit set me back a little, but here it is. I have not tested thoroughly, but it seems to work the same.
Comment 3 Carlos Soriano 2016-08-30 17:42:53 UTC
Review of attachment 334404 [details] [review]:

Makes sense to me and I cannot see anything dangerous here. Thanks Ernestas!
Comment 4 Ernestas Kulik 2016-08-30 18:13:16 UTC
Attachment 334404 [details] pushed as e92e417 - Remove NautilusEntry