After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770463 - [WIP] preliminary patch to switch GTK icons to stock GIMP icons for a more uniform look.
[WIP] preliminary patch to switch GTK icons to stock GIMP icons for a more un...
Status: RESOLVED DUPLICATE of bug 759904
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-08-26 23:23 UTC by Ben
Modified: 2016-08-26 23:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[WIP] preliminary patch to switch GTK icons to stock GIMP icons for a more uniform look. (96.39 KB, patch)
2016-08-26 23:23 UTC, Ben
none Details | Review

Description Ben 2016-08-26 23:23:54 UTC
Created attachment 334254 [details] [review]
[WIP] preliminary patch to switch GTK icons to stock GIMP icons for a more uniform look.

Preliminary patch to switch over GTK icons used by GIMP to make them stock GIMP icons and get a more uniform look in the UI.

So far i have identified 64 icons that could be switched over. List of new icon names:

gimp-document-new
gimp-document-properties
gimp-edit
gimp-edit-clear
gimp-edit-undo
gimp-edit-redo
gimp-edit-paste
gimp-edit-cut
gimp-edit-copy
gimp-edit-find
gimp-edit-delete
gimp-folder
gimp-go-previous
gimp-go-next
gimp-go-home
gimp-go-up
gimp-go-top
gimp-go-down
gimp-go-bottom
gimp-go-first
gimp-go-last
gimp-preferences-system
gimp-process-stop
gimp-tool-options
gimp-tool-changed
gimp-view-refresh
gimp-zoom-in
gimp-zoom-out
gimp-zoom-fit-best
gimp-window-close
gimp-application-exit
gimp-document-page-setup
gimp-document-print
gimp-document-properties
gimp-document-revert
gimp-document-save
gimp-edit-find
gimp-help-about
gimp-format-text-bold
gimp-format-text-italic
gimp-format-text-underline
gimp-format-text-strikethrough
gimp-list-add
gimp-list-remove
gimp-media-playback-pause
gimp-media-playback-start
gimp-media-playback-stop
gimp-media-seek-backward
gimp-media-seek-forward
gimp-media-skip-backward
gimp-media-skip-forward
gimp-help-browser
gimp-system-run
gimp-view-fullscreen
gimp-view-refresh
gimp-window-new
gimp-zoom-original
gimp-help-browser
gimp-preferences-system
gimp-dialog-information
gimp-dialog-question
gimp-image-missing

The patch doesn't currently include icons or icon code.
Comment 1 Jehan 2016-08-26 23:50:46 UTC
Hello,

Looks like a duplicate of bug 759904, no?
There was already a first attempt (by Klaus) to change the icon names into GIMP internal names. Actually he already did most of it. You can check out the branch `origin/icons-wip` on which Klaus worked. It looks like this is quite similar to your patch. Klaus already prepared the icons for all these GTK+ icon names (they are also available in the same branch).

It had not been merged because it was decided that it was not the right way to go. The proper way is to keep GTK name but load the custom icons with this name when they are available.
There is already patches by Massimo for this new behavior (bug 759904) which are under review.
Comment 2 Ben 2016-08-26 23:53:36 UTC
I hadn't seen it else i wouldn't have gone ahead with it eh.

I'll close this one.
Comment 3 Ben 2016-08-26 23:54:29 UTC
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 759904 ***