After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770170 - Unlock keyring dialog title gets truncated for keyrings with long names
Unlock keyring dialog title gets truncated for keyrings with long names
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: pkcs11
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-08-20 13:21 UTC by Felix Zhang
Modified: 2016-09-02 02:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
part of the screenshot (22.91 KB, image/png)
2016-08-20 13:21 UTC, Felix Zhang 		  Details
A patch to remove the keyring name from title. The purpose should be explained clearly in the dialog message anyway. (636 bytes, patch)
2016-08-20 13:29 UTC, Felix Zhang 		none Details | Review
A patch to keep the dialog title short. (986 bytes, patch)
2016-08-20 14:26 UTC, Felix Zhang 		none Details | Review

Description Felix Zhang 2016-08-20 13:21:40 UTC 
Created attachment 333740 [details]
part of the screenshot

The title of unlock keyring dialog is "Enter password for keyring $KEYRING_NAME to unlock". When the name of keyring is very long the title gets truncated and kind of misleading especially for some certain languages.

To make the problem valid, in a downstream bug, the reporter was trying to plug in an O2 UMTS stick and enable automated unlocking of the device when the unlock keyring and shows a title with a long keyring name as default.
Comment 1 Felix Zhang 2016-08-20 13:29:51 UTC 
Created attachment 333741 [details] [review]
A patch to remove the keyring name from title. The purpose should be explained clearly in the dialog message anyway.
Comment 2 Felix Zhang 2016-08-20 14:26:02 UTC 
Created attachment 333744 [details] [review]
A patch to keep the dialog title short.

Update patch, remove useless g_free().
Comment 3 Stef Walter 2016-08-22 09:54:59 UTC 
Makes sense. Merged to master.