GNOME Bugzilla – Bug 770161
streams: notify tag update only when tags actually changed
Last modified: 2016-08-22 07:45:47 UTC
Created attachment 333722 [details] [review] parsebin: Merge tags and update and emit signal it when the tag is changed Hello All. In playbin3 without input-selector, I think we do not keep the last taglist and we need to merge the taglist received on the parsebin for backward compatibility with input-selector. Also, we don't need to update and emit signal when taglist is not changed compared with old(last) one of similar caps in GstStream object. Thanks.
Created attachment 333723 [details] [review] streams: update and emit notify signal only if taglist actually changed
Hello All. I uploaded 2 of patches. Please check and review. I am always welcome any questions and opinions. Thanks.
Comment on attachment 333722 [details] [review] parsebin: Merge tags and update and emit signal it when the tag is changed Could you describe the use case here that fails? Tags should always be the latest state, they should not be cumulative and should not need to be merged. Maybe the issue you're seeing is fixed by the patch in bug #770053 ?
Pushed the other patch with minor modifications (commit message; allow setting it from non-NULL to NULL as well): commit a7a2623166ec907d92842a09e6dbb2ef5369b9fb Author: Hoonhee Lee <hoonhee.lee@lge.com> Date: Sat Aug 20 08:54:27 2016 +0900 streams: update and emit notify signal only if taglist actually changed https://bugzilla.gnome.org/show_bug.cgi?id=770161 Thanks for the patch! If the patch from bug #770053 didn't fix your other issue, please open a new bug and describe the problem in more detail there, thanks!
Hello Tim. Thanks for your comment. My intention is as below. 1) input-selector is not used in playbin3 as default. 2) input-selector has a role to merge taglist whenever TAG event is received. 3) I want to move and cover this behaviour to parsebin with backward compatibility. Thanks. Anyway, can you check high CPU usage in playbin3? Please refer blow links. http://gstreamer-devel.966125.n4.nabble.com/High-CPU-usage-in-multiple-audio-track-in-playbin3-td4679179.html https://harmony.lge.com:8443/issue/browse/CTRGST-288