After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770053 - parsebin: sometimes sets global tags to stream
parsebin: sometimes sets global tags to stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Mac OS
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-17 21:50 UTC by Matej Knopp
Modified: 2016-08-21 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.14 KB, patch)
2016-08-17 21:50 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2016-08-17 21:50:39 UTC 
Created attachment 333529 [details] [review]
Patch

It should check the message and only set stream tags if scope is GST_TAG_SCOPE_STREAM
Comment 1 Tim-Philipp Müller 2016-08-17 22:19:25 UTC 
Nice catch, looks right to me.

I wonder whether the global tags should go anywhere though. Maybe into the collection, or maybe the app should just grab those from the messages on the bus then. Can always be done later of course, just idly wondering.
Comment 2 Tim-Philipp Müller 2016-08-21 14:52:39 UTC 
Thanks, pushed:

commit 89554f665be585afce96aed1dd553fc761707024
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Wed Aug 17 23:49:02 2016 +0200

    parsebin: do not set global tags to stream
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770053